Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36822 )
Change subject: vendorcode/security/eltan: Allocate memory from bootmem to speed verify ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36822/6/src/vendorcode/eltan/securi... File src/vendorcode/eltan/security/verified_boot/vboot_check.c:
https://review.coreboot.org/c/coreboot/+/36822/6/src/vendorcode/eltan/securi... PS6, Line 188: (uint32_t) start > (uint32_t)(~(CONFIG_CBFS_SIZE-1)))) This checks if it's coming from SPI (because that's where the speedup is desirable), but the next clause always copies if no sufficient buffer is presented, even if the data is already in memory (AIUI boot_map_with_leak might copy). Is that what you want?
https://review.coreboot.org/c/coreboot/+/36822/6/src/vendorcode/eltan/securi... PS6, Line 201: extraneous space