15 Dec
2020
15 Dec
'20
7:39 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/em100/+/48584 )
Change subject: Add more traceable SPI commands ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/em100/+/48584/4/trace.c File trace.c:
https://review.coreboot.org/c/em100/+/48584/4/trace.c@321 PS4, Line 321: address += 16;
Yes, the address is never printed, so in theory we could decide to only count up here when we are ac […]
No, I think it is fine. Just wanted to make sure I understood the intent.
--
To view, visit https://review.coreboot.org/c/em100/+/48584
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: I9002253bf6eb7d60c90cdb75492076d5c5c48f21
Gerrit-Change-Number: 48584
Gerrit-PatchSet: 5
Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Dec 2020 18:39:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-MessageType: comment