Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43777 )
Change subject: mb/google/zork: Remove reset_gpio from bt when not supported ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43777/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c:
https://review.coreboot.org/c/coreboot/+/43777/3/src/mainboard/google/zork/v... PS3, Line 319: #if !DEVTREE_EARLY
Is this check required?
It is because this file is included in romstage and ramstage. In romstage DEVTREE_CONST is set so line 357 throws an error at compile.
https://review.coreboot.org/c/coreboot/+/43777/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/variant.c:
https://review.coreboot.org/c/coreboot/+/43777/3/src/mainboard/google/zork/v... PS3, Line 18: variant_devtree_update
If I understand correctly, this is the state of things: […]
Done