4 Jun
2019
4 Jun
'19
1:31 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32604 )
Change subject: mb/apple: Add MacBook Air 5,2 (A1466) support ......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/#/c/32604/22/src/mainboard/apple/macbookair5_2/r... File src/mainboard/apple/macbookair5_2/romstage.c:
https://review.coreboot.org/#/c/32604/22/src/mainboard/apple/macbookair5_2/r... PS22, Line 67: void mainboard_get_spd(spd_raw_data *spd, bool id_only) how can it be detected which memory configuration is used in the laptop? i think there are versions with different amounts of ram. is there some gpio strapped to some value corresponding to that?
--
To view, visit https://review.coreboot.org/c/coreboot/+/32604
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ebe6f87a8254871698be74f913b9d969d722447
Gerrit-Change-Number: 32604
Gerrit-PatchSet: 22
Gerrit-Owner: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Jun 2019 11:31:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment