[coreboot-gerrit] Change in ...coreboot[master]: arch/x86/smbios: Add type 7

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32131 )

Change subject: arch/x86/smbios: Add type 7
......................................................................

Patch Set 4: Code-Review+1

There's a lot of "magic numbers", but I don't see an easy way to replace them without making expressions huge (beyond 80 characters). Still, if possible, I would like to see shift values and masks converted to literals. You might have to break lines into multiple lines (due to 80 characters limit). That's the only reason I'm not going for a +2.
I don't care about CPUID, as I saw many other examples using magic numbers. I only care about shifts, masks, and values that are publicly available on the WEB. If a value is only on NDA documents, it's OK to have magic numbers.