Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43061 )
Change subject: soc/intel/tigerlake: Update Tigerlake SA IDs ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/43061/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43061/1//COMMIT_MSG@2 PS1, Line 2: derek.huang Please use *Derek Huang*.
$ git config --global user.name "Derek Huang" $ git commit --amend -s --author="Derek Huang derek.huang@intel.corp-partner.google.com"
https://review.coreboot.org/c/coreboot/+/43061/1//COMMIT_MSG@7 PS1, Line 7: Tigerlake Tiger Lake
https://review.coreboot.org/c/coreboot/+/43061/1//COMMIT_MSG@9 PS1, Line 9: Tigerlake Tiger Lake
https://review.coreboot.org/c/coreboot/+/43061/1//COMMIT_MSG@9 PS1, Line 9: update updates
https://review.coreboot.org/c/coreboot/+/43061/1//COMMIT_MSG@13 PS1, Line 13: Please mention that the ID of the one device is changed.
Any idea, why the other IDs were added?