Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31898 )
Change subject: tpm: Add API to query TPM presence
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/31898/5/src/drivers/spi/tpm/tpm.c
File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/#/c/31898/5/src/drivers/spi/tpm/tpm.c@468
PS5, Line 468: else
else should follow close brace '}'
Done
https://review.coreboot.org/#/c/31898/5/src/security/tpm/tis.h
File src/security/tpm/tis.h:
https://review.coreboot.org/#/c/31898/5/src/security/tpm/tis.h@101
PS5, Line 101: * This function is_tpm_detected() sets tpm_detection value to be 1 upon TPM detection.
line over 80 characters
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31898
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa7b17085364bb631f43a133839773033721062d
Gerrit-Change-Number: 31898
Gerrit-PatchSet: 7
Gerrit-Owner: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Apr 2019 16:33:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment