Attention is currently required from: Furquan Shaikh, Angel Pons, Subrata Banik, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50176 )
Change subject: soc/intel/common: Add `struct gpio_pad_table` and helpers
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/common/block/include/intelblocks/gpio.h:
https://review.coreboot.org/c/coreboot/+/50176/comment/42db234e_bd341998
PS1, Line 78: (struct gpio_pad_table)
The cast is there on purpose to allow this usage: […]
ack
https://review.coreboot.org/c/coreboot/+/50176/comment/781a1922_def13e2a
PS1, Line 81: )
when the cast gets dropped. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50176
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If029bbafe186d36a971d91b3b6b9220616e04141
Gerrit-Change-Number: 50176
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 02 Feb 2021 17:11:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment