Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38253 )
Change subject: src/superio: Add it8987e ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38253/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38253/1//COMMIT_MSG@7 PS1, Line 7: src/superio src/superio/ite
https://review.coreboot.org/c/coreboot/+/38253/1/src/superio/ite/it8987e/it8... File src/superio/ite/it8987e/it8987e.h:
https://review.coreboot.org/c/coreboot/+/38253/1/src/superio/ite/it8987e/it8... PS1, Line 19: Missing UART1 (LDN 0x01) and UART2 (LDN 0x02)
https://review.coreboot.org/c/coreboot/+/38253/1/src/superio/ite/it8987e/it8... PS1, Line 33: Double empty line
https://review.coreboot.org/c/coreboot/+/38253/1/src/superio/ite/it8987e/sup... File src/superio/ite/it8987e/superio.c:
https://review.coreboot.org/c/coreboot/+/38253/1/src/superio/ite/it8987e/sup... PS1, Line 36: static struct pnp_info pnp_dev_info[] = { I think IRQ settings aren't correct