Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50517 )
Change subject: device: Add unit to Kconfig option name: `PRE_GRAPHICS_DELAY_MS` ......................................................................
device: Add unit to Kconfig option name: `PRE_GRAPHICS_DELAY_MS`
It’s good practice to put the unit into the name.
Change-Id: I1493f61d4e495c22f09abf1829bb2eab9b1fd2b6 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Documentation/getting_started/kconfig.md M src/device/Kconfig M src/device/pci_device.c M src/mainboard/purism/librem_bdw/Kconfig 4 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/50517/1
diff --git a/Documentation/getting_started/kconfig.md b/Documentation/getting_started/kconfig.md index 037371b..dcc11b4 100644 --- a/Documentation/getting_started/kconfig.md +++ b/Documentation/getting_started/kconfig.md @@ -607,7 +607,7 @@
##### Example: - config PRE_GRAPHICS_DELAY + config PRE_GRAPHICS_DELAY_MS int "Graphics initialization delay in ms" default 0 help diff --git a/src/device/Kconfig b/src/device/Kconfig index 421ad66..8dc9ecd 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -117,7 +117,7 @@
endchoice
-config PRE_GRAPHICS_DELAY +config PRE_GRAPHICS_DELAY_MS int "Graphics initialization delay in ms" default 0 depends on VGA_ROM_RUN diff --git a/src/device/pci_device.c b/src/device/pci_device.c index cd98f07..161715f 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -734,8 +734,8 @@
static void oprom_pre_graphics_stall(void) { - if (CONFIG_PRE_GRAPHICS_DELAY) - mdelay(CONFIG_PRE_GRAPHICS_DELAY); + if (CONFIG_PRE_GRAPHICS_DELAY_MS) + mdelay(CONFIG_PRE_GRAPHICS_DELAY_MS); }
/** Default handler: only runs the relevant PCI BIOS. */ diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig index ad764b7..50c6d5b 100644 --- a/src/mainboard/purism/librem_bdw/Kconfig +++ b/src/mainboard/purism/librem_bdw/Kconfig @@ -52,7 +52,7 @@ default "1.0" if BOARD_PURISM_LIBREM13_V1 default "2.0" if BOARD_PURISM_LIBREM15_V2
-config PRE_GRAPHICS_DELAY +config PRE_GRAPHICS_DELAY_MS int default 50