build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36762 )
Change subject: spi: Add Winbond W25Q128JW_DTR SPI ROM support ......................................................................
Patch Set 1:
(20 comments)
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c File src/drivers/spi/winbond.c:
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 265: .id = 0x8018, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 265: .id = 0x8018, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 266: .l2_page_size_shift = 8, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 266: .l2_page_size_shift = 8, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 267: .pages_per_sector_shift = 4, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 267: .pages_per_sector_shift = 4, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 268: .sectors_per_block_shift = 4, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 268: .sectors_per_block_shift = 4, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 269: .nr_blocks_shift = 8, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 269: .nr_blocks_shift = 8, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 270: .name = "W25Q128JW", code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 270: .name = "W25Q128JW", please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 271: .dual_spi = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 271: .dual_spi = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 272: .protection_granularity_shift = 18, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 272: .protection_granularity_shift = 18, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 273: .bp_bits = 3, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 273: .bp_bits = 3, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 274: }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 274: }, please, no spaces at the start of a line