Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36860 )
Change subject: mb/google/drallion/variants/drallion: Update thermal configuration for DPTF ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... PS1, Line 17: 127 please share the details on how these new high values are helping compared to previous old values? Did you observe any issues with old values ? Thanks.
https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... PS1, Line 60: 15 What's the reason for changing this from 21W to 15W for PL1 Maximum value ? What's the TDP of this designed system ?
https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... PS1, Line 62: 10 Does these new lower (10000) values of TimeWindowMinimum/Maximum helping you to address any existing issues with old (28000) values ?
https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... PS1, Line 67: 4 please provide detailed reasons for changing this to such a lower value ? Did you check any performance impact with this change ?