Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35272 )
Change subject: soc/amd/common: Remove Picasso display HDA from list ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35272/2/src/soc/amd/common/block/hd... File src/soc/amd/common/block/hda/hda.c:
https://review.coreboot.org/c/coreboot/+/35272/2/src/soc/amd/common/block/hd... PS2, Line 24: PCI_DEVICE_ID_AMD_PCO_HDA1
If there's only one now, does it needs a number at the end? Should it not be simply PCI_DEVICE_ID_AM […]
I could go either way but I lean toward keeping it this way. The PPR lists two and we need to make sure we have the correct one here. Both are listed in pci_ids.h. If anything, that file is possibly misleading now, but it seems way worse to rename AMD_PCO_HDA0 TO ATI_PCO_HDA (or 0).