Attention is currently required from: Julius Werner. Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54737 )
Change subject: cbmem: Introduce "early" init hooks for console ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/include/cbmem.h:
https://review.coreboot.org/c/coreboot/+/54737/comment/85fcc495_a80c6889 PS1, Line 150: _unused_ In file included from src/lib/cbmem_console.c:5: src/lib/cbmem_console.c:153:26: error: redefinition of 'cbmemc_reinit_unused_' RAMSTAGE_CBMEM_INIT_HOOK(cbmemc_reinit) ^~~~~~~~~~~~~ src/include/cbmem.h:129:27: note: in definition of macro 'RAMSTAGE_CBMEM_INIT_HOOK' static cbmem_init_hook_t init_fn_ ## _unused_ = init_fn_; ^~~~~~~~ src/lib/cbmem_console.c:152:32: note: previous definition of 'cbmemc_reinit_unused_' was here ROMSTAGE_CBMEM_INIT_HOOK_EARLY(cbmemc_reinit) ^~~~~~~~~~~~~ src/include/cbmem.h:150:27: note: in definition of macro 'ROMSTAGE_CBMEM_INIT_HOOK_EARLY' static cbmem_init_hook_t init_fn_ ## _unused_ = init_fn_;
Add 'early' to unused so it doesn't collide? Should fix the compilation error right up.