Attention is currently required from: Karthik Ramasubramanian, Naveen M, Paul Menzel, Pranava Y N, Subrata Banik.
Varun Upadhyay has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/85282?usp=email )
Change subject: drivers/soundwire/alc711: Add common Kconfig for ALC7xx soundwire codecs ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85282/comment/8531c072_a3066fb2?usp... : PS5, Line 7: Common Kconfig for ALC7xx soundwire codecs
Please make it a statement, by adding a verb (in imperative mood): […]
Sure
https://review.coreboot.org/c/coreboot/+/85282/comment/c8b08ef8_5dbc1b4b?usp... : PS5, Line 9: This change includes the following:
Redundant and can be left out.
Sure , removed the extra lines
File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/85282/comment/bc1236c8_d075e7b2?usp... : PS5, Line 107:
don't need tab
Sure removed the extra tabs
https://review.coreboot.org/c/coreboot/+/85282/comment/12a39216_66bd8ac6?usp... : PS5, Line 116: config->alc711_address[dev->path.generic.id].link_id = dev->path.generic.id; : config->alc711_address[dev->path.generic.id].unique_id = dev->path.generic.subid;
shouldn't this be outside #if/#else case?
Sure, updated the code