Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38941 )
Change subject: nb/intel/nehalem: Rename to ironlake
......................................................................
Patch Set 4:
Patch Set 4:
Why are the cpu/ changes part of this patch? Why use `ironlake` in cpu/?
e.g. IRONLAKE_BCLK, is it related to the SA?
Well, I basically did `s/nehalem/ironlake/g` and `s/NEHALEM/IRONLAKE/g` under src/. It was the simplest way to rename a bunch of instances without affecting prints.
Also, the CPU and the SA are always connected together. Sure, the "Ironlake" name under src/cpu/ might be weird, but it is more correct than Nehalem.
With regard to `IRONLAKE_BCLK`, it is indeed related to the SA: it is the only BCLK it supports. Moreover, I would say that "HILLEL_BCLK" is too obscure (Hillel is the name of the 32nm CPU die), and CLARKDALE_ARRANDALE_BCLK` is just obnoxiously long. Therefore, I would prefer that bikeshedding be left out of this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38941
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8eb96eeb5e69f49150d47793b33e87b650c64acc
Gerrit-Change-Number: 38941
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jonathan Kollasch
jakllsch@kollasch.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Feb 2020 18:18:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment