Venkata Krishna Nimmagadda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40261 )
Change subject: mb/google/volteer: Add workaround for GPIO PM on S0ix entry/exit ......................................................................
Patch Set 4: Code-Review+1
(14 comments)
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@7 PS1, Line 7: src/mb/google/volteer: workaround for GPIO PM on s0ix entry/exit
Please make it a statement by adding a verb (in imperative mood). […]
Done
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@6 PS1, Line 6: : src/
Remove.
Done
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@10 PS1, Line 10: causing
causes
Done
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@10 PS1, Line 10: tpm
TPM
Done
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@10 PS1, Line 10: gpio pm
GPIO PM
Done
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@11 PS1, Line 11: s0ix
S0ix
Done
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@11 PS1, Line 11: had
has
Done
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@12 PS1, Line 12: asl
ASL
Done
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@12 PS1, Line 12: s0ix
S0ix
Done
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@12 PS1, Line 12: gpio pm
GPIO PM
Done
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@15 PS1, Line 15: methods
Duplicate. Remove.
Done
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@15 PS1, Line 15: This patch adds three methods platform specific methods
Dot/period at the end.
Done
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@21 PS1, Line 21: preparing to sleep
Dot/period at the end.
Done
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@24 PS1, Line 24: waking up
Dot/period at the end.
Done