[coreboot-gerrit] Change in coreboot[master]: arch/x86: Implement RESET_VECTOR_IN_RAM

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35035 )

Change subject: arch/x86: Implement RESET_VECTOR_IN_RAM
......................................................................

Patch Set 20:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35035/20/src/arch/x86/assembly_entr... 
File src/arch/x86/assembly_entry.S:

https://review.coreboot.org/c/coreboot/+/35035/20/src/arch/x86/assembly_entr... 
PS20, Line 24: 	call	gdt_init
> Aren't we in 16-bit mode on these AMD parts when get launched? What's the stack pointer value? No ca […]

By the time we get to assembly_entry.S, we're past bootblock when all that was taken care of.  This code only executes in romstage (and any home-grown verstage on Picasso).  That is, I believe the comment on line 7 is still accurate, even for Picasso.  I don't recall now whether I was using the file for the obsolete hybrid romstage, and if that muddled things.