Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30499 )
Change subject: mb/qemu-{i440fx,q35}: Use POSTCAR stage to load the ramstage
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/30499/5/src/mainboard/emulation/qemu-i440fx/...
File src/mainboard/emulation/qemu-i440fx/romstage.c:
https://review.coreboot.org/#/c/30499/5/src/mainboard/emulation/qemu-i440fx/...
PS5, Line 24: #include "memory.h"
Not required here, yet.
https://review.coreboot.org/#/c/30499/5/src/mainboard/emulation/qemu-q35/rom...
File src/mainboard/emulation/qemu-q35/romstage.c:
https://review.coreboot.org/#/c/30499/5/src/mainboard/emulation/qemu-q35/rom...
PS5, Line 25: #include "../qemu-i440fx/memory.h"
As before, not yet?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30499
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6638534d99fde312e55b6a6be8c95e4cb25cca80
Gerrit-Change-Number: 30499
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Gerd Hoffmann
kraxel@redhat.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Stefan T
stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Mar 2019 02:47:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
