4 Apr
2025
4 Apr
'25
6:43 a.m.
Attention is currently required from: Julius Werner.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/87114?usp=email )
Change subject: drivers/smmstore: Support 64-bit MMIO addresses ......................................................................
Patch Set 2:
(1 comment)
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/87114/comment/ae69486a_f3ee058e?usp... : PS1, Line 548: uint64_t mmap_addr_high; /* When the ROM MMIO address is above 4GiB the 'mmap_addr' cannot hold it.
The naming here seems very confusing to me. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/87114?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1131cfa5cdbf92bbd33de3e5b22a305136eec9f7
Gerrit-Change-Number: 87114
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Fri, 04 Apr 2025 12:43:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org