27 May
2021
27 May
'21
11:18 a.m.
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin, Karthik Ramasubramanian. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54688 )
Change subject: IMOK: Add IMOK method support for DPTF ......................................................................
Patch Set 2:
(1 comment)
File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/54688/comment/66e86fe1_780c353a PS1, Line 262: DPTF
I agree this file is already mixed with DPTF usages. If possible we should avoid adding more. […]
Sure, will add appropriate config checks as per comment.
--
To view, visit https://review.coreboot.org/c/coreboot/+/54688
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8edfa3bcaa6bde0b9690fcace000cd582dcc81d2
Gerrit-Change-Number: 54688
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Aaron Durbin adurbin@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 27 May 2021 17:18:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment