Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35679 )
Change subject: supermicro/x11-lga1151/gpio: 4/4 Convert field macros to PAD_CFG
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35679/12/src/mainboard/supermicro/x...
File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/35679/12/src/mainboard/supermicro/x...
PS12, Line 16: /* GPP_A1 - LAD0 */
Maybe I will do it in a new separate patch? I would not want to change the whole patchset or create […]
no need to redo the patchset, a separate commit will do :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35679
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idad7536854d4b1ae7dcf7934e81de438478fe059
Gerrit-Change-Number: 35679
Gerrit-PatchSet: 12
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 12 Jul 2020 08:39:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment