Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39237 )
Change subject: mb/google/dedede: Add SD card support ......................................................................
Patch Set 26:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded... PS23, Line 284: GPP_G7
Still to check on that. I'll check and update.
I checked for the below errors: [ 8.346777] mmcblk0: recovery failed! [ 8.351034] blk_update_request: I/O error, dev mmcblk0, sector 0 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0 mmc_blk_mq_rw_recovery the recovery fail is due failure to reset the card in mmc_blk_mq_complete_prev_req call. The mmc_blk_mq_complete_prev_req seems to get triggered if card continuously runs busy due to incomplete transaction as part of transfer queue.
I tried setting the GPIO to NC with pull down 20k config, to check pulling it to gnd can have similar impact. But I still the dmesg errors. The current configuration works fine.