Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32618 )
Change subject: Kconfig: Enable coreboot lite firmware flow ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/#/c/32618/3/src/Kconfig File src/Kconfig:
https://review.coreboot.org/#/c/32618/3/src/Kconfig@280 PS3, Line 280: config COREBOOT_LITE
I think CONFIG_NO_RAMSTAGE or CONFIG_SKIP_RAMSTAGE would be the most reasonable names for this.
i like SKIP_RAMSTAGE name. thanks
https://review.coreboot.org/#/c/32618/3/src/Kconfig@280 PS3, Line 280: config COREBOOT_LITE
Should that be the marketing name? […]
Done
https://review.coreboot.org/#/c/32618/3/src/Kconfig@281 PS3, Line 281: bool "Enable coreboot lite flow (remove ramstage)"
Does this need a depends on ARCH_X86 (at least for now)?
totally agree
https://review.coreboot.org/#/c/32618/3/src/Kconfig@283 PS3, Line 283: help
This should have a lot more explanation what this choice entails (e.g. […]
i can add design document later and provide link here.
for now i have added few more details as you have mentioned
https://review.coreboot.org/#/c/32618/3/src/Kconfig@285 PS3, Line 285: execute
execution?
Done
https://review.coreboot.org/#/c/32618/3/src/Kconfig@286 PS3, Line 286: Instead it is expected to load payload from postcar stage itself.
Please add a blank line above.
Done