Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47865 )
Change subject: sb/intel/ibexpeak: Use common AHCI library
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47865/2/src/southbridge/intel/ibexp...
File src/southbridge/intel/ibexpeak/sata.c:
https://review.coreboot.org/c/coreboot/+/47865/2/src/southbridge/intel/ibexp...
PS2, Line 81: const uintptr_t ahci_bar = pci_read_config32(dev, PCI_BASE_ADDRESS_5);
this should use probe_resource instead
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47865
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b636f093dfaa5954667fe0198e6602e8c1e4943
Gerrit-Change-Number: 47865
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Dec 2020 09:35:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment