Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33770 )
Change subject: soc/amd/picasso: Update southbridge
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33770/13/src/soc/amd/picasso/includ...
File src/soc/amd/picasso/include/soc/southbridge.h:
https://review.coreboot.org/c/coreboot/+/33770/13/src/soc/amd/picasso/includ...
PS13, Line 229: 0x5b
You're right. […]
LOL... last code was mine... Initial code was AMD's, one AOAC at a time. I made it all together to save wait time, though maintained registers definitions as per AMD. I like your new way.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33770
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69dfc4a875006639aa330385680d150331840e40
Gerrit-Change-Number: 33770
Gerrit-PatchSet: 14
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Sep 2019 00:01:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment