[coreboot-gerrit] Change in coreboot[master]: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )

Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h 
File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h@44 
PS3, Line 44: #define CURRENT_DSDT_REV	0x02        /* DSDT revision: ACPI v2.0 and greater */
> DSDT revision is not ACPI_FADT_REV_ACPI_xx...

Yes, I am aware of that. What I would rather like to see is something like this:

/* DSDT TABLE Revision values */
#define ACPI_DSDT_REV_ACPI_1_0		1
#define ACPI_DSDT_REV_ACPI_2_0		2
#define ACPI_DSDT_REV_ACPI_5_0		5
...

Just to follow the scheme and make it look more common.