Hello Kevin Chiu,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/47015
to review the following change.
Change subject: mb/google/octopus/variants/garg: update new LTE SKU ......................................................................
mb/google/octopus/variants/garg: update new LTE SKU
Add new SKU definition: Garg360 (LTE DB, touch, no stylus, rear camera) SKU ID - 39
BUG=b:170708728 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage
Change-Id: Ifec4e1360bd1aff3825bc6413b0a2ccd8b822075 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/garg/include/variant/sku.h M src/mainboard/google/octopus/variants/garg/variant.c 3 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/47015/1
diff --git a/src/mainboard/google/octopus/variants/garg/gpio.c b/src/mainboard/google/octopus/variants/garg/gpio.c index 67e1056..7ae59f8 100644 --- a/src/mainboard/google/octopus/variants/garg/gpio.c +++ b/src/mainboard/google/octopus/variants/garg/gpio.c @@ -71,6 +71,7 @@ return hdmi_override_table; case SKU_17_LTE: case SKU_18_LTE_TS: + case SKU_39_2A2C_360_LTE_TS_STYLUES: *num = ARRAY_SIZE(lte_override_table); return lte_override_table; default: diff --git a/src/mainboard/google/octopus/variants/garg/include/variant/sku.h b/src/mainboard/google/octopus/variants/garg/include/variant/sku.h index 8fc63cc..b325801 100644 --- a/src/mainboard/google/octopus/variants/garg/include/variant/sku.h +++ b/src/mainboard/google/octopus/variants/garg/include/variant/sku.h @@ -12,6 +12,7 @@ SKU_20_2A2C_TS = 20, SKU_37_2A2C_360 = 37, SKU_38_2A2C_360_TS_NO_STYLUES = 38, + SKU_39_2A2C_360_LTE_TS_STYLUES = 39, SKU_49_2A2C_TS = 49, SKU_50_HDMI = 50, SKU_51_2A2C = 51, diff --git a/src/mainboard/google/octopus/variants/garg/variant.c b/src/mainboard/google/octopus/variants/garg/variant.c index 0a6574d..a0ae71f 100644 --- a/src/mainboard/google/octopus/variants/garg/variant.c +++ b/src/mainboard/google/octopus/variants/garg/variant.c @@ -37,6 +37,7 @@ switch (google_chromeec_get_board_sku()) { case SKU_17_LTE: case SKU_18_LTE_TS: + case SKU_39_2A2C_360_LTE_TS_STYLUES: power_off_lte_module(); return; default: @@ -54,6 +55,7 @@ switch (google_chromeec_get_board_sku()) { case SKU_17_LTE: case SKU_18_LTE_TS: + case SKU_39_2A2C_360_LTE_TS_STYLUES: cfg->disable_xhci_lfps_pm = 1; return; default: