Attention is currently required from: Martin Roth, Furquan Shaikh, Stanley Wu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51501 )
Change subject: mb/google/dedede/var/boten: Add custom Wifi SAR for botenflex
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/dedede/variants/boten/variant.c:
https://review.coreboot.org/c/coreboot/+/51501/comment/31c002e9_90998f1a
PS4, Line 32: 0x90000
Hi Karthik, […]
Yes, it will. Can you build the variant.c for ramstage and smm? Are you seeing any build failures?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51501
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3f2529a7ad56ff306df98f77cda556656da52a5
Gerrit-Change-Number: 51501
Gerrit-PatchSet: 5
Gerrit-Owner: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Henry Sun
henrysun@google.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Thu, 08 Apr 2021 00:05:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment