build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31591 )
Change subject: mediatek/mt8183: add dsi driver for mt8183
......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/#/c/31591/11/src/soc/mediatek/mt8183/dsi.c
File src/soc/mediatek/mt8183/dsi.c:
https://review.coreboot.org/#/c/31591/11/src/soc/mediatek/mt8183/dsi.c@65
PS11, Line 65: data_rate = (u64)(edid->mode.pixel_clock * 1000 * bit_per_pixel) / lanes;
line over 80 characters
https://review.coreboot.org/#/c/31591/11/src/soc/mediatek/mt8183/dsi.c@253
PS11, Line 253: struct mtk_phy_timing *phy_timing, u32 lanes)
line over 80 characters
https://review.coreboot.org/#/c/31591/11/src/soc/mediatek/mt8183/dsi.c@477
PS11, Line 477: mtk_dsi_config_vdo_timing(mode_flags, format, edid, &phy_timing, lanes);
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31591
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic413f524ca0b36f0b01f723a71fe9745e2710cd2
Gerrit-Change-Number: 31591
Gerrit-PatchSet: 11
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 May 2019 11:36:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment