Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31630 )
Change subject: mb/intel/saddlebrook: Fix 2nd DIMM slot
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31630/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31630/1//COMMIT_MSG@11
PS1, Line 11:
Maybe add more details (your comment from the review):
I believe this should have changed to spd_array[1] after blk.add_map was
modified after patchset 7. I would asssume 2nd DIMM slot to currently not
work.
https://review.coreboot.org/#/c/31630/1//COMMIT_MSG@12
PS1, Line 12: Change-Id: I213853d2b981294554d8d1b254da476905a41c13
Fixes: commit 4dee7b52 (mainboard/intel/saddlebrook: add support for Saddle Brook)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31630
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I213853d2b981294554d8d1b254da476905a41c13
Gerrit-Change-Number: 31630
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Teo Boon Tiong
boon.tiong.teo@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Boon Tiong Teo
boon.tiong.teo@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Feb 2019 09:53:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment