5 Jan
2021
5 Jan
'21
12:56 a.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48144 )
Change subject: mb/kontron/mal10: Remove unnecessary includes ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/include/carrier/gpio.h:
https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... PS9, Line 6: #include <gpio.h>
uhm... that's definitely wrong lol. "soc/gpio.h" should be used here. […]
oh well, it fits better in "use explicit includes", ignore that one here
--
To view, visit https://review.coreboot.org/c/coreboot/+/48144
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895
Gerrit-Change-Number: 48144
Gerrit-PatchSet: 9
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 Jan 2021 23:56:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment