Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32549 )
Change subject: SKL: Add ACPI brightness control ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/32549/5/src/soc/intel/skylake/acpi/globalnvs... File src/soc/intel/skylake/acpi/globalnvs.asl:
https://review.coreboot.org/#/c/32549/5/src/soc/intel/skylake/acpi/globalnvs... PS5, Line 74: Put a tab here instead of spaces.
https://review.coreboot.org/#/c/32549/5/src/soc/intel/skylake/acpi/globalnvs... PS5, Line 75: same as above.
https://review.coreboot.org/#/c/32549/5/src/soc/intel/skylake/graphics.c File src/soc/intel/skylake/graphics.c:
https://review.coreboot.org/#/c/32549/5/src/soc/intel/skylake/graphics.c@128 PS5, Line 128: 0x2 Add info on this value as comment. If possible make this as #define.