Attention is currently required from: Shelley Chen, Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe RC driver in Coreboot ......................................................................
Patch Set 9:
(26 comments)
File src/soc/qualcomm/sc7280/include/soc/addressmap.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/117bb28c_afe1b293 PS9, Line 68: #define PCIE1_MEM_SIZE 0x1fd00000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/ec39182f_08f73f13 PS9, Line 69: #define PCIE_MEM_END 0x404fffff please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/f476b677_09716972 PS9, Line 72: #define PCIE_1_QMP_PHY 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/1a702de2_b9fe4277 PS9, Line 76: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
File src/soc/qualcomm/sc7280/include/soc/pcie.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/45438585_08a49a71 PS9, Line 18: #define DEV_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/5a653136_0e81ad0f PS9, Line 19: #define CLASS_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/261531d2_8da6a023 PS9, Line 20: #define HEADER_SZ 8 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/5a4bdd2b_4c54d992 PS9, Line 21: #define VEND_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/be3cb32a_63d62ecc PS9, Line 25: #define PCIE_CLASS 0x0a please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/c2069017_2ab6a025 PS9, Line 26: #define PCI_MAX_DEV_FN 0x100 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/5fea0ead_8b816d72 PS9, Line 41: #define PCIE1_3x2_NUM_LANES 2 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/18d94c7d_692c0d5f PS9, Line 57: #define PERST_DELAY_US 1000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/ec6fa1db_e1dfcb53 PS9, Line 58: #define PCIE_MAX_BARS 6 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/6b72de4a_a63266f8 PS9, Line 154: #define PCIE1_QMP_PHY_PCS_COM 0x01C0EA00 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/c722efd2_9ea60c6c PS9, Line 155: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/be8d5104_ce2dbca6 PS9, Line 156: #define PCE1_QPHY_TX0 0x01C0E200 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/26842e02_b1cf6d23 PS9, Line 157: #define PCE1_QPHY_RX0 0x01C0E400 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/c1315793_882d3631 PS9, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/dbfedbf6_39589aaf PS9, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/d8503ff2_08b54285 PS9, Line 188: #define PCIE_DEV(_bus, _dev, _fn) (0x80000000 | \ Macros with complex values should be enclosed in parentheses
File src/soc/qualcomm/sc7280/pcie_host.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/159a396c_b014dea4 PS9, Line 303: pci_ep_cfg_info.config_base = (void*)PCIE1_GEN3x2_CONF; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/f8da87a4_83fd2c65 PS9, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/432eb8f3_f918e6be PS9, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/5c44a62e_569d498f PS9, Line 468: printk(BIOS_NOTICE,"pcie ep PERST desserted\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/0427fa55_c6a32071 PS9, Line 773: if (vend_id == 0xffff || vend_id == 0x0000) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120311): https://review.coreboot.org/c/coreboot/+/53902/comment/455fabbb_05b4bf8a PS9, Line 1140: if(!ret) space required before the open parenthesis '('