David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32222 )
Change subject: mb/facebook/watson: Disable turbo ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32222/2/src/mainboard/facebook/watson/Kconfi... File src/mainboard/facebook/watson/Kconfig:
https://review.coreboot.org/#/c/32222/2/src/mainboard/facebook/watson/Kconfi... PS2, Line 45: def_bool n
Why the Kconfig?
The requirement for whether or not turbo is enabled in all cases is not well-defined, and >1 customer may deploy this board. So this gives them flexibility to change this setting by enabling/disabling it in the config they use rather than changing code.
Some day I hope to have this and other settings that different users may want to change stored in VPD.
https://review.coreboot.org/#/c/32222/2/src/mainboard/facebook/watson/mainbo... File src/mainboard/facebook/watson/mainboard.c:
https://review.coreboot.org/#/c/32222/2/src/mainboard/facebook/watson/mainbo... PS2, Line 6: -present
A copyright notice should state each year when (a part of) […]
Thanks for bringing this up. I actually went back and checked our legal template and as it happens one of the lawyers modified it last year and removed this part (see patch set 3).
BTW, I'm not a lawyer but I'm pretty sure copyright extends well past the next year. The "-present" thing only made it so people don't try to change the copyright line every time a file is updated. I'm sure we can find plenty of examples in the coreboot tree where people needlessly changed copyright years which in fact makes things a lot more confusing if the origin of the code were ever in dispute.