Attention is currently required from: Michał Żygowski, Michał Kopeć.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68919 )
Change subject: intelblocks/cse: Add functions to check and change PTT state ......................................................................
Patch Set 3:
(10 comments)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/68919/comment/d0fe4217_bcf6c692 PS3, Line 1078: int enum cb_err
https://review.coreboot.org/c/coreboot/+/68919/comment/38109e47_0820736c PS3, Line 1099: feature_status fw_runtime_status?
https://review.coreboot.org/c/coreboot/+/68919/comment/c7f65b5f_0af470d3 PS3, Line 1123: 0 CB_ERR?
https://review.coreboot.org/c/coreboot/+/68919/comment/8e4dcb0a_0401db1b PS3, Line 1127: 0 CB_ERR?
https://review.coreboot.org/c/coreboot/+/68919/comment/846bbdf2_355a1ff3 PS3, Line 1132: ; CB_ERR?
https://review.coreboot.org/c/coreboot/+/68919/comment/e8cb72bd_2f7c734c PS3, Line 1137: return 1; CB_SUCCESS?
https://review.coreboot.org/c/coreboot/+/68919/comment/3d43bb0a_fe868d41 PS3, Line 1158: HMRFPO Enable FW FEATURE SHIPMENT TIME STATE OVERRIDE ?
https://review.coreboot.org/c/coreboot/+/68919/comment/07e573e7_06872228 PS3, Line 1180: HFSTS1 FW Inti Complete is set 5) Before EOP issued to CSE
It is good to add the condition for completeness though the API doesn't verifies. Agree?
https://review.coreboot.org/c/coreboot/+/68919/comment/f98b8641_db7ccc29 PS3, Line 1189: cse_get_fw_feature_state Need to update the if condition based on my comments (cb_success:0. cb_err:non_zero) .
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/68919/comment/461084f7_ece4cc80 PS3, Line 574: Returns 0 on failure and 1 on success. This needs update.