build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38118 )
Change subject: [DO-NOT-SUBMIT]: treeya: override edid for old AUO panel ......................................................................
Patch Set 1:
(15 comments)
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 91: 0x00, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x06, 0xAF, 0x5C, 0x61, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 92: 0x00, 0x1B, 0x01, 0x04, 0x95, 0x1A, 0x0E, 0x78, 0x02, 0x99, 0x85, 0x95, 0x55, 0x56, 0x92, 0x28, line over 96 characters
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 93: 0x22, 0x50, 0x54, 0x00, 0x00, 0x00, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, line over 96 characters
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 94: 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x66, 0x1C, 0x56, 0xA0, 0x50, 0x00, 0x19, 0x30, 0x30, 0x20, line over 96 characters
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 95: 0x46, 0x00, 0x00, 0x90, 0x10, 0x00, 0x00, 0x18, 0x00, 0x00, 0x00, 0x0F, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 96: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x20, 0x00, 0x00, 0x00, 0xFE, 0x00, 0x41, line over 96 characters
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 97: 0x55, 0x4F, 0x0A, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x00, 0x00, 0xFE, line over 96 characters
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 98: 0x00, 0x42, 0x31, 0x31, 0x36, 0x58, 0x41, 0x4E, 0x30, 0x36, 0x2E, 0x31, 0x20, 0x0A, 0x00, 0x06 line over 96 characters
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 137: u8 *edidbuffer = (uint8_t*)(uint)((X86_ES <<4) + X86_DI); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 137: u8 *edidbuffer = (uint8_t*)(uint)((X86_ES <<4) + X86_DI); need consistent spacing around '<<' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 141: switch(X86_EAX & 0xffff) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 146: memcpy(edidbuffer, target_edid_auo_b116xan06p1 , sizeof(target_edid_auo_b116xan06p1)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 146: memcpy(edidbuffer, target_edid_auo_b116xan06p1 , sizeof(target_edid_auo_b116xan06p1)); space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 173: if( boardid == 4) { space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/38118/1/src/mainboard/google/kahlee... PS1, Line 173: if( boardid == 4) { space required before the open parenthesis '('