build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37353 )
Change subject: [ALTERNATIVE] binaryPI: implement C bootblock
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37353/2/src/drivers/amd/agesa/bootb...
File src/drivers/amd/agesa/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37353/2/src/drivers/amd/agesa/bootb...
PS2, Line 32: void (*ap_romstage_entry)(void) = (void (*)(void))get_ap_entry_ptr();
function definition argument 'void' should also have an identifier name
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37353
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d8888904425ed524e279c6c3223fbf07f2c4506
Gerrit-Change-Number: 37353
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 29 Nov 2019 11:13:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment