Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43418 )
Change subject: soc/amd/picasso: use FADT devicetree configuration options ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43418/1/src/soc/amd/picasso/acpi.c File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/43418/1/src/soc/amd/picasso/acpi.c@... PS1, Line 129: fadt->iapc_boot_arch = cfg->fadt_boot_arch; /* legacy free default */
Hrm, instead of allowing one to arbitrarily override this, maybe use an `enable_8042` option?
hm, good question. are you ok with getting this merged in its current state that at least properly sorts out the fadt_flags handling and I'll try to have a look into the fadt_boot_arch in a follow-up?
https://review.coreboot.org/c/coreboot/+/43418/1/src/soc/amd/picasso/acpi.c@... PS1, Line 132: fadt->flags = cfg->fadt_flags;
Or even better: have devicetree options to enable such options instead of directly poking FADT. […]
I added all mandatory and soc-specific options directly here and just add the board specific ones in the devicetree. while this might not be perfect, it's still much better than the old version of this patch