Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 )
Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ......................................................................
Patch Set 29:
(3 comments)
Done for the last things. I need to do a new test in the motherboard to confirme everything works but I'can do it yet.
https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c:
https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... PS26, Line 27: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x1401);
I need to chek if this is not an error, it should de default to (0x0000) […]
Done
https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... PS26, Line 28: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0000);
I think you can remove both
Done
https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c:
https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... PS26, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
you can delete this file.
Done