13 Oct
2020
13 Oct
'20
8:43 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46286 )
Change subject: superio/nuvoton: Only set bit 7 of global CR 0x2a for COM A ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46286/3/src/superio/nuvoton/common/... File src/superio/nuvoton/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/46286/3/src/superio/nuvoton/common/... PS3, Line 62: pnp_write_config(dev, 0x2a, 0x00);
Looks like I misread the datasheet back in CB:33640 because it has two sections for bit 7: https://i […]
https://4donline.ihs.com/images/VipMasterIC/IC/NUTC/NUTC-S-A0001770713/NUTC-...
--
To view, visit https://review.coreboot.org/c/coreboot/+/46286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ded9dab3985c4c8e5c45af354ef44af482e18c2
Gerrit-Change-Number: 46286
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Teo Boon Tiong boon.tiong.teo@intel.com
Gerrit-Comment-Date: Tue, 13 Oct 2020 17:43:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment