Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45343 )
Change subject: device/dram: Add method for converting MHz to MT/s
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45343/1/src/device/dram/ddr4.c
File src/device/dram/ddr4.c:
https://review.coreboot.org/c/coreboot/+/45343/1/src/device/dram/ddr4.c@27
PS1, Line 27: [DDR4_1866]{
Looks like it's an obsolete, but valid syntax for gcc: https://gcc.gnu. […]
Oh no, GNU extensions! 😭
(GNU extensions aren't very well defined, which can cause problems in the long run)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1433f028afb794fe3e397b03f5bd0565494c8130
Gerrit-Change-Number: 45343
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Sep 2020 15:59:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment