Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44155 )
Change subject: sb/intel/lynxpoint: Consider root ports being disabled by strap
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44155/2/src/southbridge/intel/lynxp...
File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/44155/2/src/southbridge/intel/lynxp...
PS2, Line 108: * +-----+----+----+----+----+
: * | RPC | #5 | #6 | #7 | #8 |
: * +-----+----+----+----+----+
: * | 0 | x1 | x1 | x1 | x1 |
: * | 1 | x2 | | x1 | x1 |
: * | 2 | x2 | | x2 | |
: * | 3 | x4 | | | |
: * +-----+----+----+----+----+
Are you by chance referring to this part of the datasheet? https://imgur.com/QrElUnO.png
It mentions both ports 1-4 and ports 5-8, it's just clumped together though.
No PECR4 (0xfc) bits 14-15.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44155
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6da3a1f45467f00002a5ed41df8650f4a74eeba
Gerrit-Change-Number: 44155
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 04 Aug 2020 16:47:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment