Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43979 )
Change subject: drivers/intel/fsp2_0: Change boot state notification
......................................................................
Patch Set 4:
Patch Set 4:
(2 comments)
Does anyone know why we load the payload into memory and then notify FSP? Doesn't it make sense to:
- notify FSP of boot state init
- load payload into memory
- run payload
we have 2 FSP callback
1. Post PCI enumeration
2. Ready to Boot
I guess the purpose of NotifyPhaseApi() - Begin [Phase: 00000040]
FSP Ready To Boot ... event to ensure we have a done with all operation and bootloader is ready to handoff to payload/os
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43979
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I122edc12abf992cb3e5ec53747a7cef9c94aee8e
Gerrit-Change-Number: 43979
Gerrit-PatchSet: 4
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 29 Jul 2020 17:37:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment