[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp2_0: Make FSP_USE_REPO an SOC opt-in instead of list...

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37582 )

Change subject: drivers/intel/fsp2_0: Make FSP_USE_REPO an SOC opt-in instead of list dependency
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37582/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37582/6//COMMIT_MSG@7 
PS6, Line 7: drivers/intel/fsp2_0: Make FSP_USE_REPO an SOC opt-in instead of list dependency
Summary has 50 characters limit

https://review.coreboot.org/c/coreboot/+/37582/6/src/soc/intel/cannonlake/Kc... 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/c/coreboot/+/37582/6/src/soc/intel/cannonlake/Kc... 
PS6, Line 68: 	select HAVE_INTEL_FSP_REPO
> Select this option by each SOC at the beginning of the file, except SOC_INTEL_CANNONLAKE

You also could just use `if !SOC_INTEL_CANNONLAKE`