Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43659 )
Change subject: vc/amd/fsp/picasso: update UPD header ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43659/2/src/vendorcode/amd/fsp/pica... File src/vendorcode/amd/fsp/picasso/FspsUpd.h:
https://review.coreboot.org/c/coreboot/+/43659/2/src/vendorcode/amd/fsp/pica... PS2, Line 20: /** Offset 0x00C0**/ uint32_t ddi_descriptor[FSPS_UPD_DDI_DESCRIPTOR_COUNT];
my plan with these two patches is to hand them over to Raul after I've looked into how to properly do the binary interface version checking and added the changes needed for that on the FSP side, so that he can make sure that the chromebook firmware images that are automatically built will never contain mismatched versions