build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29164 )
Change subject: mainboard/intel/icelake_rvp: Do initial mainboard commit ......................................................................
Patch Set 4:
(12 comments)
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/chro... File src/mainboard/intel/icelake_rvp/chromeos.c:
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/chro... PS4, Line 42: /* Lid always open */ code indent should use tabs where possible
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/chro... PS4, Line 43: return 1; code indent should use tabs where possible
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/chro... PS4, Line 43: return 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/chro... PS4, Line 48: return 0; code indent should use tabs where possible
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/chro... PS4, Line 48: return 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/spd/... File src/mainboard/intel/icelake_rvp/spd/spd_util.c:
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/spd/... PS4, Line 26: 0x0F, 0xF0, 0x0F, 0xF0, 0xFF, 0x00 , space prohibited before that ',' (ctx:WxE)
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/vari... File src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/vari... PS4, Line 314: CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), code indent should use tabs where possible
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/vari... PS4, Line 314: CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), please, no spaces at the start of a line
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/vari... PS4, Line 319: *num = ARRAY_SIZE(cros_gpios); code indent should use tabs where possible
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/vari... PS4, Line 319: *num = ARRAY_SIZE(cros_gpios); please, no spaces at the start of a line
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/vari... PS4, Line 320: return cros_gpios; code indent should use tabs where possible
https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/vari... PS4, Line 320: return cros_gpios; please, no spaces at the start of a line