Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32301 )
Change subject: soc/intel/cannonlake: Enable coreboot MP PPI service for WHL/CML
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32301/1/src/soc/intel/cannonlake/Kconfig
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/32301/1/src/soc/intel/cannonlake/Kconfig@31
PS1, Line 31: USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
This depends on PLATFORM_USES_FSP2_1 which is not selected for WHL or CML: https://review.coreboot. […]
From ICL onward all platform supported with FSP2.1 can select this config as is, but WHL/CML might not compatible with FSP2.1 spec right now hence we can't select the same config. Rather we are using USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI to enable MP service.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I530d50e5aacc3cb9b625df14a50d4c5923e3fb4d
Gerrit-Change-Number: 32301
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 15 Apr 2019 04:03:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment