Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42094 )
Change subject: amd/00730F01: Clean the Microcode updating ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42094/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42094/4//COMMIT_MSG@10 PS4, Line 10: https://review.coreboot.org/c/coreboot/+/41719
I can’t see the summary in patch set 5.
Done. It is in patch set 6. I just changed the code and edited gerrit at same time. Sometimes the gerrit is uploaded before git is pushed. Sorry for that.
https://review.coreboot.org/c/coreboot/+/42094/4/src/cpu/amd/pi/00730F01/upd... File src/cpu/amd/pi/00730F01/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/42094/4/src/cpu/amd/pi/00730F01/upd... PS4, Line 104: m = (struct microcode *)c; : : if (m->processor_rev_id == equivalent_processor_rev_id) : apply_microcode_patch(m);
I'm ok with keeping the code in it's current form, but please add a comment about this issue, becaus […]
Done. The comment was added. And more detailed description is added into git log.