Attention is currently required from: Yu-Ping Wu. Hello Hung-Te Lin, build bot (Jenkins), Jakub Czapiga,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56543
to look at the new patch set (#5).
Change subject: helpers: Add GENMASK and GENMASK_ULL macros ......................................................................
helpers: Add GENMASK and GENMASK_ULL macros
The GENMASK is defined in multiple files (with various names such as MASKBIT), which sets certain consecutive bits to 1 and leaves the others to 0. To avoid duplicate macros, add GENMASK and GENMASK_ULL macros to helpers.h, for unsigned long and unsigned long long types, respectively.
GENMASK(h, l) sets bits from `h` to `l` (inclusive) to 1. For example, GENMASK_ULL(39, 21) gives us the 64-bit vector 0x000000ffffe00000.
Remove duplicate macro definitions. Also utilize GENMASK for _BF_MASK in mmio.h.
BUG=none TEST=make tests/commonlib/bsd/helpers-test TEST=emerge-cherry coreboot BRANCH=none
Change-Id: If2e7c4827d8a7d27688534593b556a72f16f0c2b Signed-off-by: Yu-Ping Wu yupingso@chromium.org --- M src/commonlib/bsd/include/commonlib/bsd/helpers.h M src/include/device/mmio.h M src/soc/mediatek/common/pll.c M src/soc/mediatek/mt8195/dptx_hal.c M src/soc/mediatek/mt8195/include/soc/dptx_hal.h M src/soc/qualcomm/sc7180/include/soc/qcom_qup_se.h M tests/commonlib/bsd/helpers-test.c 7 files changed, 42 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/56543/5